[SYCL] Use pair of native::sin/cos for sincos under __FAST_MATH__ #10481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
changed the title
|
Performance measurements have been done in https://github.com/intel/llvm/actions/runs/5790366639/job/15693313789. |
| @@ -734,8 +734,8 @@ std::enable_if_t<__FAST_MATH_GENFLOAT(T), T> sin(T x) __NOEXC { | |||
|
|
|||
| // svgenfloat sincos (svgenfloat x, genfloatptr cosval) | |||
| template <typename T, typename T2> | |||
| std::enable_if_t< | |||
| detail::is_svgenfloat<T>::value && detail::is_genfloatptr<T2>::value, T> | |||
| std::enable_if_t<__FAST_MATH_GENFLOAT(T) && detail::is_genfloatptr<T2>::value, | |||
There was a problem hiding this comment.
I'm not sure where __FAST_MATH_WITH_GENFLOAT comes from or what it is, but is there any chance that these two enable_if might both be true at the same time and then result in an ambiguous call? Do you need to ensure they are mutuallly exclusive?
There was a problem hiding this comment.
I've tried to do it exactly the same as done for sin/cos/...
|
This PR could affect #10198 |
cperkinsintel
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.